Add support for mixed bcs in (EB)godunov PLM and MacProjector #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in 2D. Still need to check 3D and update God (as regualar boxes in EB runs will go to regular God)
boxes in EB sim will get here.
asalmgren
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the MacProjector, allow specifying Robin BCs (since mixed BCs can be viewed as a special case of this).
For (EB)Godunov, this has been implemented by allowing the option to pass a position dependent BC MF/Array4. The BC MF is cell-centered and carries the amrex::BCType type in the first ghost cell (precedent set by MLMG's treatment of Robin BCs) and must fully specify the BC on all faces. If a position dependent BCs are passed in, they take precedent and single bc per face BCRecs are ignored.